jeanouii commented on a change in pull request #93:
URL: https://github.com/apache/openjpa/pull/93#discussion_r811243718
##########
File path: openjpa/pom.xml
##########
@@ -129,48 +129,19 @@
</artifactSet>
<relocations>
<relocation>
-
<pattern>javax.annotation.security</pattern>
-
<shadedPattern>jakarta.annotation.security</shadedPattern>
+ <pattern>javax.annotation</pattern>
+
<shadedPattern>jakarta.annotation</shadedPattern>
+ <excludes>
+
<exclude>javax.annotation.process.**</exclude>
+ </excludes>
</relocation>
<relocation>
-
<pattern>javax.annotation.Generated</pattern>
-
<shadedPattern>jakarta.annotation.Generated</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.PostConstruct</pattern>
-
<shadedPattern>jakarta.annotation.PostConstruct</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.PreDestroy</pattern>
-
<shadedPattern>jakarta.annotation.PreDestroy</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.Resource</pattern>
-
<shadedPattern>jakarta.annotation.Resource</shadedPattern>
- </relocation>
- <relocation>
-
<pattern>javax.annotation.Resources</pattern>
-
<shadedPattern>jakarta.annotation.Resources</shadedPattern>
- </relocation>
- <relocation>
- <pattern>javax.el</pattern>
Review comment:
Indeed and on purpose. There is no use of EL in OpenJPA. So no need to
have them in my opinion.
##########
File path: openjpa/pom.xml
##########
@@ -179,34 +150,18 @@
<relocation>
<pattern>javax.transaction</pattern>
<shadedPattern>jakarta.transaction</shadedPattern>
+ <excludes>
+
<exclude>javax.transaction.xa.**</exclude>
+ </excludes>
</relocation>
<relocation>
<pattern>javax.validation</pattern>
<shadedPattern>jakarta.validation</shadedPattern>
</relocation>
<relocation>
- <pattern>javax.persistence</pattern>
-
<shadedPattern>jakarta.persistence</shadedPattern>
+ <pattern>javax.xml.bind</pattern>
+
<shadedPattern>jakarta.xml.bind</shadedPattern>
</relocation>
- <relocation>
- <pattern>javax.faces</pattern>
Review comment:
Same here for Faces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
