gjevardat commented on code in PR #111: URL: https://github.com/apache/openjpa/pull/111#discussion_r1221072220
########## openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/schema/Constraint.java: ########## @@ -250,31 +241,48 @@ public String toString() { return "<" + name.toLowerCase() + ">"; } - @Override Review Comment: I used an auto generated eclipse equals and hashcode. I could mimic the style of the original one indeed. The important thing for me is the fields that are included in the equality and hashcode testing to avoid the mem leak ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org