Small update: I've worked on it over the last few weeks, and I'm getting closer
https://github.com/struberg/openjpa/tree/fb_asmEnhance contains the latest work on the PCEnhancer. Right in the middle of replacing Serp with native ASM code. Note that I also had to modify a few interfaces with a few more to follow from BCClass to ASM ClassNode. Happy to get some feedback! If anybody wants to help with this effort I'm happy to also push this feature branch to our ASF repo. It looks reasonably promising already. LieGrue, strub > Am 25.05.2023 um 18:36 schrieb Mark Struberg <strub...@yahoo.de.INVALID>: > > Hi! > > Right now I'm trying to get rid of serp step by step. > The code is right now at my own github repo in the fb_asmEnhance branch: > https://github.com/struberg/openjpa/tree/fb_asmEnhance > > > > The approach I took for now is to create a few methods in AsmHelper to be > able to move from BCClass -> ASM ClassWriter and the other way around. That > way we should be able to replace functionality part by part but still keep > all things afloat. > > For now I've started with the PCSubclassValidator. > Right now this evaluates the attributs using Serp plus ASM and then compare > the results. > If something is fishy, you'll see the following > throw new IllegalStateException("MSX ASMTODO " + bcField + " " + field); > > > It would be extremely helpful, if you could go through your projects and let > it run and report how it's going. > If you see that "MSX ASMTODO" somewhere then we know I messed something up. > > I'll gonna finally remove the BCClass handling from those parts in a few > days. Current commit is > https://github.com/struberg/openjpa/commit/3ea2412003028d37f2a69971a47bb20abf589f8b > > txs and LieGrue, > strub > > > >
