[ 
https://issues.apache.org/jira/browse/OPENJPA-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916748#comment-17916748
 ] 

Maxim Solodovnik edited comment on OPENJPA-2930 at 1/24/25 3:17 PM:
--------------------------------------------------------------------

{quote}Closeable interface could be replaced project wide by java native 
Autocloseable, but it is not necessary.{quote}

Removing this one would introduce API break, this should happen with major 
version increase

{quote}still got no answer about my pull requests #121 and 122{quote}

#121 was just merged, #122 has conflicts, but I'm looking at it (sorry for 
extremely slow responses, too few free time :((( )

{quote}Could you please help me on OPENJPA-2933? I'm struggling to figure how I 
should change JPQL.jjt file to support EXTRACT function{quote}

to be fair I have no idea, closest example I can see would be

{code}
void trim() #TRIM : { }
{
        <TRIM> "(" [LOOKAHEAD(2)[trim_specification()] [trim_character()] 
<FROM>]
                string_expression() ")"
}
{code}

so maybe something like this:

{code}
void date_part_specification() : { }
{
        LOOKAHEAD(1) (<MICROSECOND> #MICROSECOND) | <SECOND> #SECOND | 
......................................)
}

void extract() #EXTRACT : { }
{
        <EXTRACT> "(" date_part_specification() <FROM> datetime_expression() ")"
}
{code}

[~romain.manni-bucau], [~struberg] maybe you can help? :))


was (Author: solomax):
{quote}Closeable interface could be replaced project wide by java native 
Autocloseable, but it is not necessary.{quote}

Removing this one would introduce API break, this should happen with major 
version increase

{quote}still got no answer about my pull requests #121 and 122{quote}

#121 was just merged, #122 has conflicts, but I'm looking at it (sorry for 
extremely slow responses, too few free time :((( )

{quote}Could you please help me on OPENJPA-2933? I'm struggling to figure how I 
should change JPQL.jjt file to support EXTRACT function{quote}

to be fair I have no idea, closes example I can see would be

{code}
void trim() #TRIM : { }
{
        <TRIM> "(" [LOOKAHEAD(2)[trim_specification()] [trim_character()] 
<FROM>]
                string_expression() ")"
}
{code}

so maybe something like this:

{code}
void date_part_specification() : { }
{
        LOOKAHEAD(1) (<MICROSECOND> #MICROSECOND) | <SECOND> #SECOND | 
......................................)
}

void extract() #EXTRACT : { }
{
        <EXTRACT> "(" date_part_specification() <FROM> datetime_expression() ")"
}
{code}

[~romain.manni-bucau], [~struberg] maybe you can help? :))

> UUID ID Generator Strategy 
> ---------------------------
>
>                 Key: OPENJPA-2930
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2930
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jpa
>    Affects Versions: 4.0.1
>            Reporter: hantsy bai
>            Assignee: Maxim Solodovnik
>            Priority: Major
>
>  The issue https://issues.apache.org/jira/browse/OPENJPA-2908 implements JPA 
> 3.1 was fixed, but I tried to use `UUID` as the ID of the Entity class in my 
> example https://github.com/hantsy/jakartaee10-starter-boilerplate/pull/162, 
> which use Apache TOMEE 10 as runtime, the tests are failed due to the lack of 
> UUID support.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to