solomax commented on code in PR #122: URL: https://github.com/apache/openjpa/pull/122#discussion_r1928865647
########## openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/exps/Ceiling.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.jdbc.kernel.exps; + +import java.math.BigDecimal; +import java.math.BigInteger; + +import org.apache.openjpa.kernel.Filters; + +/** + * Ceiling value. + */ +public class Ceiling + extends UnaryOp { + + + private static final long serialVersionUID = 1L; + + /** + * Constructor. Provide the value to operate on. + */ + public Ceiling(Val val) { + super(val); + } + + @Override + protected Class getType(Class c) { + Class wrap = Filters.wrap(c); + if (wrap == Integer.class + || wrap == Float.class + || wrap == Double.class + || wrap == Long.class + || wrap == BigDecimal.class + || wrap == BigInteger.class) + return Filters.unwrap(c); Review Comment: could you please add `{}` here :) ########## openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Floor.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.kernel.exps; + +import java.math.BigDecimal; +import java.math.BigInteger; + +import org.apache.openjpa.kernel.Filters; + +/** + * Take the floor value of a number. + */ +class Floor + extends UnaryMathVal { + + + private static final long serialVersionUID = 1L; + + /** + * Constructor. Provide the number whose floor value will be calculated. + */ + public Floor(Val val) { + super(val); + } + + @Override + protected Class getType(Class c) { + Class wrap = Filters.wrap(c); + if (wrap == Integer.class + || wrap == Float.class + || wrap == Double.class + || wrap == Long.class + || wrap == BigDecimal.class + || wrap == BigInteger.class) + return Filters.unwrap(c); + return int.class; + } + + @Override + protected Object operate(Object o, Class c) { + c = Filters.wrap(c); + if (c == Integer.class) + return Math.abs(((Number) o).intValue()); Review Comment: also `abs` .... :( ########## openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Ceiling.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.kernel.exps; + +import java.math.BigDecimal; +import java.math.BigInteger; + +import org.apache.openjpa.kernel.Filters; + +/** + * Take the ceiling value of a number. + */ +class Ceiling + extends UnaryMathVal { + + + private static final long serialVersionUID = 1L; + + /** + * Constructor. Provide the number whose ceiling value to calculate. + */ + public Ceiling(Val val) { + super(val); + } + + @Override + protected Class getType(Class c) { + Class wrap = Filters.wrap(c); + if (wrap == Integer.class + || wrap == Float.class + || wrap == Double.class + || wrap == Long.class + || wrap == BigDecimal.class + || wrap == BigInteger.class) + return Filters.unwrap(c); + return int.class; + } + + @Override + protected Object operate(Object o, Class c) { + c = Filters.wrap(c); + if (c == Integer.class) + return Math.abs(((Number) o).intValue()); Review Comment: are you sure there should `abs` here? ########## openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/criteria/CriteriaTest.java: ########## @@ -20,6 +20,12 @@ import jakarta.persistence.EntityManager; +import java.sql.Connection; Review Comment: these seems to be redundant ########## openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Floor.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.kernel.exps; + +import java.math.BigDecimal; +import java.math.BigInteger; + +import org.apache.openjpa.kernel.Filters; + +/** + * Take the floor value of a number. + */ +class Floor + extends UnaryMathVal { + + + private static final long serialVersionUID = 1L; + + /** + * Constructor. Provide the number whose floor value will be calculated. + */ + public Floor(Val val) { + super(val); + } + + @Override + protected Class getType(Class c) { + Class wrap = Filters.wrap(c); + if (wrap == Integer.class + || wrap == Float.class + || wrap == Double.class + || wrap == Long.class + || wrap == BigDecimal.class + || wrap == BigInteger.class) + return Filters.unwrap(c); Review Comment: `{}` :) ########## openjpa-kernel/src/main/java/org/apache/openjpa/kernel/exps/Ceiling.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openjpa.kernel.exps; + +import java.math.BigDecimal; +import java.math.BigInteger; + +import org.apache.openjpa.kernel.Filters; + +/** + * Take the ceiling value of a number. + */ +class Ceiling + extends UnaryMathVal { + + + private static final long serialVersionUID = 1L; + + /** + * Constructor. Provide the number whose ceiling value to calculate. + */ + public Ceiling(Val val) { + super(val); + } + + @Override + protected Class getType(Class c) { + Class wrap = Filters.wrap(c); + if (wrap == Integer.class + || wrap == Float.class + || wrap == Double.class + || wrap == Long.class + || wrap == BigDecimal.class + || wrap == BigInteger.class) + return Filters.unwrap(c); Review Comment: `{}` :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
