rzo1 commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3689045213
##########
.gitignore:
##########
@@ -11,3 +11,11 @@ nbactions*.xml
.checkstyle
.vscode
+.claude
Review Comment:
Good catch, and it went deeper than the .gitignore. `docker-compose.yml` was
deliberately removed in a80a08e6d ("run-tck32.sh is improved to use dockers
from pom") — the TCK now starts its database via docker-maven-plugin from
`run-tck32.sh`, so there is no compose file any more and the README Quick Start
was pointing at a file that no longer exists (plus stale `5433` / `openjpa`
defaults; the script actually uses `5555` / `tcktest`).
Fixed in 562c90d31:
- dropped `docker-compose.yml`, `pgdata` and `tck-dev` from `.gitignore` —
all leftovers of the compose setup
- rewrote the TCK README to match what the script really does (auto-started
container unless `DB_HOST` is set, correct defaults, the other supported
`DB_TYPE` values, corrected prerequisite list)
Kept `.claude` / `CLAUDE.md` for now — happy to move those to a global
gitignore instead if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
