solomax commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3801567144
##########
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/jdbc/sqlcache/TestExternalizedParameter.java:
##########
@@ -56,48 +56,44 @@ public void setUp() throws Exception {
}
}
+ /**
+ * Verifies that a query with a non-externalized parameter executes
+ * correctly.
+ */
public void testNoFalseAlarmOnExternalizedParameterDetection() {
String jpql = "select b from Book b where b.title=:title";
EntityManager em = emf.createEntityManager();
- QueryExpressions[] exps = getExpressions(em.createQuery(jpql)
+ List<?> result = em.createQuery(jpql)
.setParameter("title","XYZ")
- .getResultList());
- assertNotNull(exps);
-
- assertFalse(isUsingExternalizedParameter(exps[0]));
+ .getResultList();
+ assertNotNull(result);
}
+ /**
+ * Verifies that a query with an externalized parameter (token maps
+ * to an enum via ExternalValues) executes correctly.
+ */
public void testCanDetectExternalizedSingleParameterValue() {
Review Comment:
@rzo1 these were your changes :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
