Maxim Solodovnik created OPENJPA-2987:
-----------------------------------------

             Summary: Externalized-parameter tests reduced to no-op assertions
                 Key: OPENJPA-2987
                 URL: https://issues.apache.org/jira/browse/OPENJPA-2987
             Project: OpenJPA
          Issue Type: Sub-task
          Components: jpa
    Affects Versions: 4.2.0
            Reporter: Maxim Solodovnik
            Assignee: Romain Manni-Bucau
             Fix For: 4.2.0


Discussion thread: 
https://github.com/apache/openjpa/pull/144#discussion_r3683006222


**(high)** These three tests kept their names ("CanDetectExternalized...") but 
no longer detect anything: the `getExpressions()` helper was deleted and the 
`isUsingExternalizedParameter(...)` assertions were replaced by 
`assertNotNull(getResultList())`, which can never fail. Was 
externalized-parameter detection actually removed from the prepared-query 
cache, or can the original assertions be restored? As written the tests are 
no-ops.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to