[
https://issues.apache.org/jira/browse/OPENJPA-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106176#comment-18106176
]
Maxim Solodovnik commented on OPENJPA-2995:
-------------------------------------------
[~romain.manni-bucau] Different DBs have slightly different reserved keywords
list. Plus for whatever reason keyword escaping is something treated as
unnecessary
I do remember I saw test creating DB table with name TABLE and checking it
wasn't escaped ...
there are lots of tests checking SQL matches exactly and they were failing
I can add method comment like above
Would it be sufficient?
> assertSQL now ignores identifier delimiters suite-wide
> ------------------------------------------------------
>
> Key: OPENJPA-2995
> URL: https://issues.apache.org/jira/browse/OPENJPA-2995
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 4.2.0
> Reporter: Maxim Solodovnik
> Assignee: Maxim Solodovnik
> Priority: Major
> Fix For: 4.2.0
>
>
> Discussion thread:
> https://github.com/apache/openjpa/pull/144#discussion_r3683007396
> **(medium)** assertSQL() now also matches after stripping identifier
> delimiters (same idea as the new same() helper in
> AbstractCriteriaTestCase.java:159). This globally relaxes every SQL assertion
> in the suite and would mask regressions in delimited-identifier handling.
> Could the delimiter-insensitive comparison be opt-in, or at least documented
> why it became necessary?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
