solomax commented on code in PR #153:
URL: https://github.com/apache/openjpa/pull/153#discussion_r3820643212
##########
openjpa-kubernetes/src/test/java/org/apache/openjpa/event/kubernetes/KubernetesTCPRemoteCommitProviderTest.java:
##########
@@ -138,14 +140,17 @@ public void addresses() throws Exception {
@Override
protected KubernetesClient kubernetesClient() throws
KubernetesClientException {
- return server.getClient();
+ // a fresh client per invocation, as done by the base
implementation:
+ // fetchDynamicAddresses() closes the client it is given, so
handing out the
+ // shared client of the mock server would make every
subsequent refresh fail
+ // and hence drop all addresses again
+ return server.getKubernetesMockServer().createClient();
Review Comment:
this seems to be the correct fix :))
I've tried to fix it with correct timeouts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
