[
https://issues.apache.org/jira/browse/OPENJPA-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106263#comment-18106263
]
ASF subversion and git services commented on OPENJPA-2981:
----------------------------------------------------------
Commit 1cc206da5981d91defff2c26654603c4cdc6747e in openjpa's branch
refs/heads/OPENJPA-2981 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=1cc206da5 ]
[OPENJPA-2981] Remove dead access-type helper methods
Remove the private helpers hasMixedAnnotations(Class, OpenJPAConfiguration),
hasFieldStrategyAnnotations(Class) and hasGetterStrategyAnnotations(Class) from
PersistenceMetaDataDefaults. All three were private and had no callers anywhere
in the code base.
They were added in b53766529 ("[OPENJPA-2940] Allow mixed FIELD+PROPERTY
annotation placement without @Access") as a draft shape of the mixed-annotation
access resolution; the version that actually shipped in that commit was written
inline in determineImplicitAccessType(...), so the helpers were unused from the
moment they were introduced. Commit 58ffe9c53 ("[OPENJPA-2940] Fix
AccessDefiningFilter for dual-annotated entities and mappedBy resolution") then
rewrote that inline logic and removed the last live uses of the
accessTypeFilter field, leaving its only remaining references inside the dead
helpers.
Consequently the accessTypeFilter field and the AccessTypeFilter nested filter
class, which after that rework are reachable only from the removed methods, are
dropped as well. No other member or import becomes unused.
Raised in review of PR 144.
> Dead access-type annotation helper methods
> ------------------------------------------
>
> Key: OPENJPA-2981
> URL: https://issues.apache.org/jira/browse/OPENJPA-2981
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 4.2.0
> Reporter: Maxim Solodovnik
> Priority: Major
> Fix For: 4.2.0
>
>
> Discussion thread:
> https://github.com/apache/openjpa/pull/144#discussion_r3683005121
> **(medium)** `hasMixedAnnotations`, `hasFieldStrategyAnnotations` (547) and
> `hasGetterStrategyAnnotations` (556) are never called from anywhere - dead
> code from an earlier iteration of the access-type rework; suggest removing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
