rzo1 opened a new pull request, #160: URL: https://github.com/apache/openjpa/pull/160
Removes `JDBCBrokerFactory.dropExcludedTypeTables` as suggested in https://issues.apache.org/jira/browse/OPENJPA-2959. The review was right on both counts: it built raw `"DROP TABLE " + name` SQL without `toDBName`/quoting or CASCADE handling, and it swallowed every failure at trace level — but the real problem is that dropping a user table because its type was excluded from synchronization is destructive, and an excluded type may well be a table managed outside OpenJPA on purpose. It was also test-driven rather than a feature: `git log` traces it to 682623b6d, whose message says it exists "so operations against non-existent entity tables fail as expected", and the only consumer of `SyncMappingsExcludeTypes` anywhere in the tree is `tck32-openjpa-profile.xml` for `entityManager2.DoesNotExist`. Excluding the type from schema creation — the part that is kept — is the actual feature; the drop only papered over a table left behind by an earlier run against a reused database. Six imports become unused and were removed with it. No test in the tree exercises `ExcludeTypes`, and the `persistence.schema.**` / `persistence.jdbc.schema.**` selection returns exactly the same 5 failures / 28 errors on this branch as on master (all pre-existing, unrelated harness issues). One thing to confirm on your side: if a TCK re-run against an already-populated container regresses `DoesNotExist`, the cleanup belongs in `run-tck32.sh` (recreate the DB) rather than in the broker factory — happy to add that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
