[ 
https://issues.apache.org/jira/browse/OPENJPA-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106621#comment-18106621
 ] 

ASF subversion and git services commented on OPENJPA-2955:
----------------------------------------------------------

Commit 1b3a6ef392d6cf74a5d0471b9bc2d32cff32160a in openjpa's branch 
refs/heads/OPENJPA-2955 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=1b3a6ef39 ]

[OPENJPA-2955] Do not remove schema generation keys from the caller's 
properties map


> extractSchemaGenObjects mutates caller's properties map
> -------------------------------------------------------
>
>                 Key: OPENJPA-2955
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2955
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683000132
> **(medium)** `extractSchemaGenObjects` calls `map.remove(key)` on the 
> caller-supplied properties map - this mutates user configuration and throws 
> UnsupportedOperationException for unmodifiable maps (e.g. `Map.of(...)` 
> passed to `createEntityManagerFactory`). Can the Writer/Reader values be 
> captured without mutating the input?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to