[
https://issues.apache.org/jira/browse/OPENJPA-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18106998#comment-18106998
]
ASF subversion and git services commented on OPENJPA-2978:
----------------------------------------------------------
Commit 8719892cdadd22aa2b9d614c4a428b9decea8ec6 in openjpa's branch
refs/heads/master from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=8719892cd ]
[OPENJPA-2978] Fix typos and stray semicolon in SchemaManagerImpl
Removes the stray second semicolon in truncate(), drops the redundant
(Exception) cast when constructing SchemaValidationException, and corrects
the 'concretelly' javadoc typo. The Strucuture/Struture method name typos
reported in review were already corrected on master and need no change.
> Typos, stray semicolon, and validate() masking unsupported
> ----------------------------------------------------------
>
> Key: OPENJPA-2978
> URL: https://issues.apache.org/jira/browse/OPENJPA-2978
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 4.2.0
> Reporter: Maxim Solodovnik
> Priority: Major
> Fix For: 4.2.0
>
>
> Discussion thread:
> https://github.com/apache/openjpa/pull/144#discussion_r3683004763
> **(medium)** Nits before this freezes: the delegated `BrokerFactory` method
> names carry the `Strucuture`/`Struture` typos, `truncateData();;` has a
> double semicolon at line 64, and the `(Exception) ex` cast at line 58 is
> redundant. Also `validate()` wraps even UnsupportedOperationException from
> stores that do not implement validation into
> `SchemaValidationException("Schema could not be validated: null")`,
> misreporting a missing capability as a validation failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
