[ 
https://issues.apache.org/jira/browse/OPENJPA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18110028#comment-18110028
 ] 

ASF subversion and git services commented on OPENJPA-2967:
----------------------------------------------------------

Commit 2a8b0e24ef6180926390896ca7d6408403854389 in openjpa's branch 
refs/heads/OPENJPA-2967 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=2a8b0e24e ]

[OPENJPA-2967] Brace the blocks touched by this change

Review feedback.


> VersionVal NPEs on surrogate or missing version
> -----------------------------------------------
>
>                 Key: OPENJPA-2967
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2967
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683002730
> **(medium)** `getColumns()` NPEs when the entity has a surrogate version or 
> no version at all (`getVersionFieldMapping()` returns null), so `VERSION(e)` 
> on such an entity dies with NullPointerException instead of a meaningful 
> error - `initialize` should validate this like it validates the class 
> mapping. The error at line 99 also reuses the `bad-getobjectid` message, 
> which is misleading for a VERSION() failure.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to