solomax commented on code in PR #198:
URL: https://github.com/apache/openjpa/pull/198#discussion_r4119172154
##########
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreQuery.java:
##########
@@ -567,6 +581,35 @@ private Number executeBulkOperation(ClassMetaData[] metas,
subclasses, exps[i], state[i],
EagerFetchModes.EAGER_NONE);
+ if (cleanupOwnedTables) {
+ List<ForeignKey> joins = getOwnedTableJoins(mappings[i],
+ subclasses);
+ if (!joins.isEmpty()) {
+ sel.addJoinClassConditions();
+ if (isUnfiltered(sel) && !hasConstantJoin(joins)) {
+ // every row of every owned table belongs to a deleted
+ // candidate, so there is nothing to materialize
+ if (owned == null)
Review Comment:
I would use `{}` everywhere :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
