[ 
https://issues.apache.org/jira/browse/OPENJPA-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121380#comment-18121380
 ] 

ASF subversion and git services commented on OPENJPA-2994:
----------------------------------------------------------

Commit e0b008952889fb24bc3829738af8d78873170b7d in openjpa's branch 
refs/heads/OPENJPA-2990 from Paulo Cristovão de Araújo Silva Filho
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=e0b008952 ]

[OPENJPA-2994] Added try-with-resource in test


> Map-key column default KEY0 to entityCs_KEY breaks upgrades
> -----------------------------------------------------------
>
>                 Key: OPENJPA-2994
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2994
>             Project: OpenJPA
>          Issue Type: Sub-task
>          Components: jpa
>    Affects Versions: 4.2.0
>            Reporter: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
> Discussion thread: 
> https://github.com/apache/openjpa/pull/144#discussion_r3683007155
> **(medium)** Changing the expected default map-key column from KEY/KEY0 to 
> entityCs_KEY (also TestContainerSpecCompatibilityOptions.java:426 and the 
> KEY0 -> photos_KEY expected SQL in TestTypesafeCriteria) is spec-correct, but 
> silently changes DDL/SQL against existing schemas created by older OpenJPA 
> versions - upgrades will not find the KEY0 column. Should this be gated 
> behind a compatibility option (this test class exists exactly for that) and 
> called out in migration notes?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to