[
https://issues.apache.org/jira/browse/OPENJPA-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18123781#comment-18123781
]
ASF subversion and git services commented on OPENJPA-2973:
----------------------------------------------------------
Commit b4bfa57f0c03f07a2c3053ff9a9820ec94471ae9 in openjpa's branch
refs/heads/master from Paulo Cristovão de Araújo Silva Filho
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=b4bfa57f0 ]
Merge pull request #201 from apache/OPENJPA-2973
[OPENJPA-2973] Consult the AttributeConverter for null values
> Converter instantiated reflectively, skips CDI and nulls
> --------------------------------------------------------
>
> Key: OPENJPA-2973
> URL: https://issues.apache.org/jira/browse/OPENJPA-2973
> Project: OpenJPA
> Issue Type: Sub-task
> Components: jpa
> Affects Versions: 4.2.0
> Reporter: Maxim Solodovnik
> Priority: Major
> Fix For: 4.2.0
>
>
> Discussion thread:
> https://github.com/apache/openjpa/pull/144#discussion_r3683003654
> **(low)** Two questions: (1) the converter is instantiated via
> `getDeclaredConstructor().newInstance()`, bypassing CDI-managed converters
> (JPA allows converters as CDI beans with injection); (2) why
> reflection/`findMethod` instead of casting to
> `jakarta.persistence.AttributeConverter` and calling it directly? Note also
> the `val == null` short-circuits mean a converter mapping null to a default
> value is never consulted for nulls.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
