rzo1 opened a new pull request, #207: URL: https://github.com/apache/openjpa/pull/207
Six tests from the owned-table cleanup and the map-key column option asserted the SQL shape Derby and H2 emit, so a full MySQL run failed — reported by @solomax on the dev list. Two causes: MySQL and MariaDB render an unqualified bulk delete as `DELETE t0 FROM T t0` rather than `DELETE FROM T`, so the assertions now accept an alias on either side of the `FROM`; and the legacy map key column is spelled differently by every dictionary (`KEY` where the word is legal, `KEY0` where it is renamed, a delimited `key` where it is quoted instead), so that assertion compares the generated DDL without delimiters and without case. Test-only change — the product behaviour was correct on each database. Verified on five dictionaries (the ten bulk-delete and compat classes): Derby 39, H2 39, MySQL 8.0 38, MariaDB 11.8 38, all clean; PostgreSQL 11 was already passing before the change. For the record, the failures reproduce on master as 6 on MySQL and 5 on MariaDB (MariaDB renames the reserved word, so it escapes the map-key one). Worth a follow-up discussion: the Actions matrix runs only `test-derby` and `test-h2`, so nothing on a pull request exercises MySQL, MariaDB or PostgreSQL, which is how these got in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
