solomax commented on code in PR #222:
URL: https://github.com/apache/openjpa/pull/222#discussion_r4365749919
##########
openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ConverterValueHandler.java:
##########
@@ -54,12 +57,46 @@ public Column[] map(ValueMapping vm, String name, ColumnIO
io,
DBIdentifier colName = DBIdentifier.newColumn(name,
dict != null ? dict.delimitAll() : false);
+ adjustLobColumns(vm, _dbType);
Column col = new Column();
col.setIdentifier(colName);
- col.setJavaType(JavaTypes.getTypeCode(_dbType));
+ col.setJavaType(getColumnJavaType(_dbType));
return new Column[]{ col };
}
+ /**
+ * The column java type for the converter's database type. A byte array
+ * is read and written as bytes, not as an object.
+ */
+ static int getColumnJavaType(Class<?> dbType) {
+ if (dbType == byte[].class)
Review Comment:
I would add `{}` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
