solomax commented on PR #233: URL: https://github.com/apache/openjpa/pull/233#issuecomment-6459871696
> 1. looks up the literal key profile, not the loop variable good catch, will be fixed :) > 2. derby is in FULL_DB_LIST now, so stopAll runs -Ptest-derby-docker noticed this, but thought it is "not a bit deal" :) will try to fix it :) > 3. Before, setting DB_HOST meant no container was started ........ Either keep the old default or update the usage text. Aha, I forget to update `README.md` file Will be fixed > 4. for mssql, DB_USER=SA overrides whatever user was passed in. The new default password TcktestPwd13 now applies to every database, not just mssql user was always ignored for `MSSQL` so I see no issue here, same remark to the passwd (the reason default was changed: `MSSQL` performs password validation and fails to start) other databases will not suffer :) > 4. still lists MySQL 8.0 and PostgreSQL 11, which are EOL (see the dev@ thread and https://github.com/apache/openjpa/pull/234) will be addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
