rzo1 commented on PR #41: URL: https://github.com/apache/openjpa/pull/41#issuecomment-6573701327
The bug is still there on master: `In.toKernelExpression` calls `_exps.clear()` and rebuilds the list, which changes the user's CriteriaQuery. Problems with the current patch: - `copy()` creates `new In<>(e)` but doesn't carry over the negation, so `NOT IN` silently becomes `IN`. - The test prints to `System.err` and asserts against an invented `toString()` value. - The branch no longer applies (javax → jakarta). A simpler fix would be to build a local list of `Equal` expressions instead of changing `_exps`. Would you like to update the PR? Otherwise we'll take it over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
