rzo1 opened a new pull request, #265: URL: https://github.com/apache/openjpa/pull/265
https://issues.apache.org/jira/browse/OPENJPA-3064 **Stacked on #264** (and #263): it uses `DBDictionary.isUnsizedDecimal` from #263. Only the last three commits belong to this PR. Fixes the 13 failures and 13 errors of the suite on SQL Server (`-Dtest-mssql-docker`): - **Decimals** (`TestDecimalScale`, `TestUnarySign`, `TestArithmeticResultType`): an unsized `DECIMAL` is `DECIMAL(18,0)` on SQL Server. Sized columns keep `(p, s)`; a decimal column of a non-integral type without a precision is created as `DECIMAL(38, scale)`, the mapped scale or 10, at most 38. Same approach as #263 and #264. Migration note added. - **`EXTRACT(SECOND)`** keeps the fraction (`DATEPART(SECOND)` plus the nanoseconds), as OPENJPA-3055 did for MySQL. - **`EXTRACT(WEEK)`** uses `DATEPART(ISO_WEEK, ...)`. - **`TestJava8TimeTypes.testGetCurrentLocalTime`**: the test compared the database's LOCAL TIME with the JVM clock, which fails when the database runs in another time zone. It now compares with the database clock (test only). - **Dropping a column** (`TestFlushModeAutoNavigation`, `TestTckFixes`, `TestTreatJoinOnEmbeddable`, `TestEmbeddableCriteria`): SQL Server refuses `ALTER TABLE ... DROP COLUMN` while an index, primary key or constraint uses the column. `SQLServerDictionary` now drops those first when the schema tool drops a column. New tests in `TestSQLServerDictionary`. Full suite passes on SQL Server 2022, Derby and H2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
