[ 
https://issues.apache.org/jira/browse/OPENJPA-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137887#comment-18137887
 ] 

ASF subversion and git services commented on OPENJPA-3060:
----------------------------------------------------------

Commit 4030e0a58345226e8e62bc6a2276d40275de7255 in openjpa's branch 
refs/heads/OPENJPA-3059 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=4030e0a58 ]

[OPENJPA-3060] Store chars as CHAR by default on MariaDB (#261)

OPENJPA-3001 turned StoreCharsAsNumbers off by default for MySQL only.
MariaDBDictionary does not extend MySQLDictionary, so char and Character
attributes were still stored as INTEGER code points on MariaDB and a
pre-existing CHAR(1) column did not work. Set the same default there; an
explicit StoreCharsAsNumbers=true is still respected.

Cover MySQL and MariaDB in TestStoreCharsAsNumbersDefaults and in the
default check of TestCharStorage, let TestJDBCEscapeDate treat MariaDB
like MySQL, and list MariaDB in the migration note.

> MariaDB: StoreCharsAsNumbers still defaults to true
> ---------------------------------------------------
>
>                 Key: OPENJPA-3060
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-3060
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 4.2.0
>
>
> OPENJPA-3001 turned {{StoreCharsAsNumbers}} off by default for MySQL, so 
> {{char}}/{{Character}} attributes are stored in {{CHAR(1)}} columns. 
> {{MariaDBDictionary}} does not extend {{MySQLDictionary}} and did not get the 
> change, so on MariaDB these attributes are still stored as {{INTEGER}} code 
> points and a pre-existing {{CHAR(1)}} column (as in the Jakarta Persistence 
> TCK schema) does not work.
> The 4.2 migration note "char attributes are stored as CHAR(1)" lists MySQL 
> but not MariaDB.
> Also two tests check for {{MySQLDictionary}} only and skip MariaDB: 
> {{AbstractLobTest}} and the fractional timestamp branch of 
> {{TestJDBCEscapeDate}}.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to