rzo1 commented on code in PR #281:
URL: https://github.com/apache/openjpa/pull/281#discussion_r4495789995


##########
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/jdbc/query/bulk/BulkDeleteSharedA.java:
##########
@@ -45,8 +45,7 @@ public class BulkDeleteSharedA {
     @PersistentCollection
     @ContainerTable(name = "BULK_SHARED_COLL",
         joinColumns = {
-            @XJoinColumn(name = "OWNER_ID", referencedColumnName = "ID",
-                columnDefinition = "BIGINT"),

Review Comment:
   Yes, it was a test issue. `columnDefinition` is taken as is for the DDL, 
that is what it is meant for, so OpenJPA should not rewrite it. Oracle has no 
`BIGINT` type. Without the `columnDefinition` the dictionary picks the type of 
the referenced `ID` column (`bigintTypeName`, `NUMBER` on Oracle), which is 
what the test needs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to