[
https://issues.apache.org/jira/browse/OPENJPA-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Richard Zowalla resolved OPENJPA-2090.
--------------------------------------
Resolution: Won't Fix
Closing as obsolete during backlog cleanup: The rules are now inline in the
root pom.xml (checkstyleRules, pom.xml:2114-2137) and every module inherits
them, so openjpa-project/checkstyle.xml is no longer referenced anywhere. One
leftover: suppressions.xml is still loaded by file path, and 9 module poms
override checkstyle.suppressions.location with a relative path (e.g.
openjpa-examples/pom.xml:42). That is optional and small, and it is not the
separate rules artifact this issue asked for. Please reopen if this still
happens with OpenJPA 4.x.
> factor out openjpa-project/checkstyle.xml to own maven project
> --------------------------------------------------------------
>
> Key: OPENJPA-2090
> URL: https://issues.apache.org/jira/browse/OPENJPA-2090
> Project: OpenJPA
> Issue Type: Improvement
> Components: build / infrastructure
> Affects Versions: 2.2.0
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Priority: Major
>
> Currently our build scripts adopt a file-based way to reference our
> checkstyle configuration. With having lots of sub-modules with a deeply
> nested structure, this introduces quite some maintenance effort (e.g. when
> you try to add integration tests).
> There is another way to incorporate checkstyles for a project easily: serve
> them in an own maven artifact and include them as dependency of the
> maven-checkstyle-plugin.
> See OpenWebBeans and MyFaces of how this looks like:
> https://svn.apache.org/repos/asf/openwebbeans/build-tools/trunk/ for the
> openwebbeans-checkstyle-rules, and
> https://svn.apache.org/repos/asf/openwebbeans/trunk/pom.xml for how it's
> being used (see maven-checkstyle-plugin section)
> This can e.g. also be used to detect missing ASF headers in java files, etc.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
