[ 
https://issues.apache.org/jira/browse/OPENJPA-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18142441#comment-18142441
 ] 

ASF subversion and git services commented on OPENJPA-3074:
----------------------------------------------------------

Commit 5c7d590090a1211af76180cede28a63a65df7e06 in openjpa's branch 
refs/heads/OPENJPA-3074 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=5c7d59009 ]

[OPENJPA-3074] Test the version dependent settings of MySQLDictionary

The temporal types with a fraction of a second from MySQL 5.7, XML columns
from 5.1, the subselect flags before 4.1, the product version of a driver
that is not JDBC 3 compliant and the blob deserialization of a driver
before Connector/J 5.


> Share the common code of MySQLDictionary and MariaDBDictionary in a 
> superclass and add the MySQL 8 reserved words
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OPENJPA-3074
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-3074
>             Project: OpenJPA
>          Issue Type: Improvement
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 4.2.0
>
>
> MySQLDictionary and MariaDBDictionary both extend DBDictionary and duplicate 
> most of their code, as noted in the review of #297 (OPENJPA-2943). Move the 
> shared code into a common abstract superclass and keep the per-database 
> differences and defaults in the two subclasses. All public configuration 
> fields stay as they are.
> MySQLDictionary also lacks the reserved words MySQL 8.0 added, such as RANK, 
> ROW_NUMBER, WINDOW and LATERAL. An entity attribute named rank therefore 
> produces a CREATE TABLE statement that fails on MySQL 8.4 and 9.x.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to