rzo1 commented on PR #305: URL: https://github.com/apache/openjpa/pull/305#issuecomment-6821000169
One thing about `openjpa-junit5`: with this PR the module depends on `junit-jupiter-api` and `junit-platform-commons` 6.x in compile scope. Anyone who uses `openjpa-junit5` with JUnit 5 then gets the JUnit 6 API on the classpath transitively, mixed with their own Jupiter 5 engine/platform. I would keep the artifact name: it is published since 3.x (`org.apache.openjpa:openjpa-junit5`, package `org.apache.openjpa.junit5`), and "junit5" stands for the Jupiter model, which JUnit 6 keeps; renaming it to `junit6` would break users and need renaming again with the next major. Instead I would make the JUnit dependencies `provided`, so the user's JUnit version wins, and maybe change only the display name/description to "OpenJPA JUnit Jupiter". I'll prepare that, together with the rebase onto master and the conversion of the tests that came with OPENJPA-3075. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
