[ 
https://issues.apache.org/jira/browse/OPENJPA-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144374#comment-18144374
 ] 

ASF subversion and git services commented on OPENJPA-3007:
----------------------------------------------------------

Commit 7e242c709a340d56122dfa0fb269c1edf2ba3eea in openjpa's branch 
refs/heads/OPENJPA-3007 from Richard Zowalla
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=7e242c709 ]

[OPENJPA-3007] Let TestMappingToolRefresh create EntityBoolChar itself rather 
than reuse the table another test left

TestJDBCSchemaManager leaves EntityBoolChar with the native boolean column 
(BIT(1), BOOLEAN), and the 'add'
schema action never changes an existing column, so inserting '1' as STRING_10 
failed on MySQL, MariaDB and
PostgreSQL depending on the test order. The first stage now uses 
SchemaAction='drop,add'.


> Junit6 should be used for tests
> -------------------------------
>
>                 Key: OPENJPA-3007
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-3007
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: build / infrastructure
>    Affects Versions: 4.1.1
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Major
>             Fix For: 4.2.0
>
>
>  - Junit6 should be used for tests
>  - various 
> {code}
>     <dependencies>
>         <dependency>
>             <groupId>junit</groupId>
>             <artifactId>junit</artifactId>
>         </dependency>
>     </dependencies>
> {code}
> blocks (added at 0e8b4abfb04d02d9bf9a862b14b8afadc88f3445) should be removed
>  - {{TestEmbeddableCriteria.countTestMethods}} need to be carefully migrated
>  - various {{assertSQL}}, {{assertNotSQL}}, {{assertAllSQL*}}, 
> {{assertSQLFragnments}} need to be unified
>  - Tests like 
> {{openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/conversion/TestConvertedInPlaceChange.java}}
>  {{testElementOfConvertedListRestoredOnRollback}} need to be converted to 
> parametrized



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to