19 instances, not 29. Next, I will get a calculator and learn to add ...
On 19-Oct-07, at 3:33 PM, Paul Spencer wrote: > For those of you that are not on IRC, Tim and I worked this out > this afternoon and I committed: > > http://trac.openlayers.org/changeset/5028 > > which cleans up some 29 instances of local scope variables used > without 'var', making them global in scope. This is now part of my > regularly scheduled routine :) > > Cheers > > Paul > > On 19-Oct-07, at 1:30 PM, Tim Schaub wrote: > >> Hey- >> >> Paul Spencer wrote: >>> >>> for the record, I did fix the above warnings in Rico/* and did >>> NOT touch >>> firebug. As Tim indicates, it doesn't affect the final build. >>> As of >>> now, the final full build is 'lint free' with my current >>> settings, which >>> makes me very happy :) I may look at some of the other settings >>> to see >>> if there is anything else we could potentially benefit from in >>> the newer >>> version of jslint which I discovered last night ... >>> >> >> Paul, I'd also be interested in the result of disallowing use of >> undefined variables. Perhaps you already talked about this and I >> missed it. >> >> What would be really cool is if jslint could be tweaked to look for >> variable assignment outside of the OpenLayers namespace - >> something we >> occasionally stumble across and have no way of testing for. (I >> know a >> case where window.i == 2 and I cannot figure out why.) This might >> even >> be caught by the "no undefined variables" filter if it is initialized >> without the var keyword (which is likely). >> >> Tim >> >>> Cheers >>> >>> Paul >>> >>> +-----------------------------------------------------------------+ >>> |Paul Spencer [EMAIL PROTECTED] | >>> +-----------------------------------------------------------------+ >>> |Chief Technology Officer | >>> |DM Solutions Group Inc http://www.dmsolutions.ca/ | >>> +-----------------------------------------------------------------+ >>> >>> >>> >>> >>> >>> >>> !DSPAM:4033,4718de8133771961014482! >>> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://openlayers.org/mailman/listinfo/dev > > +-----------------------------------------------------------------+ > |Paul Spencer [EMAIL PROTECTED] | > +-----------------------------------------------------------------+ > |Chief Technology Officer | > |DM Solutions Group Inc http://www.dmsolutions.ca/ | > +-----------------------------------------------------------------+ > > > > > +-----------------------------------------------------------------+ |Paul Spencer [EMAIL PROTECTED] | +-----------------------------------------------------------------+ |Chief Technology Officer | |DM Solutions Group Inc http://www.dmsolutions.ca/ | +-----------------------------------------------------------------+ _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
