Hi, Christian López Espínola píše v Pá 02. 11. 2007 v 17:58 +0100: > Hi Jachym, > > > what do you understand with "test" ? Is it working demo? > > He is talking about Unit Tests. > See "How to create a patch", http://trac.openlayers.org/wiki/CreatingPatches, > where you'll find how to write those unit tests.
New thinks to learn, all right :-) > > > IMHO, the patch with new feature should be accepted always, unless there > > is some serious reason for not accepting it. Patches in general are > > supposed to add new features - make the software more customizable for > > everyones needs. If now I'm the only one, who needs it, who can say, > > there will be nobody in the future? > > I understand your frustration, but the patches have to been reviewed. > New code brings new bugs, so OL devs have to be cautious with it. My > experience show me that new features patches need more time than bug > fixes for going into the trunk, but if they are good, they'll go. > I have contributed some patch to OL. Some of them are into the trunk, > but otherst still not. Anyway, if someone needs them, they can find > them in the trac and apply them on their local copy or sandbox. > Patience :-) No, that is my problem: trunk is always changing. I'm not able to provide up to date patches for months. After then, reviewer just says, the patch could not be applied, and that was it. > > > If I understand your last sentence right - we are expected to keep our > > patches fresh for several weeks or months? If so, I would have to ask, > > if there could be some better development model(?). > > I have contributed to some opensource projects, not only OL, and my > experience shows me that the development model in OL is one of the > betters I have participated. Code reviews, unit tests, the great way > of using trac... Anyway, if you know how to improve it, I'm sure all > of us will be glad of reading suggestions :-) OL is also not the only project, I know and I was contributing to. I do not say, the model is bad. I do just lack _any_ feedback for several months. > > > It is not going only about this one issue - I have several other > > improvements, Marker/Label.js, Popup.js, LayerSwitcher.js and others. > > But I'm asking myself, if it is worth the work, to prepare patches, if > > nobody even reviews them :-( > > If they improve the OL framework, I'm sure they'll be welcome. OK. How shall I do it? 1) prepare patch 2) write example 3) write unit test - wait, till somebody will drop it - update all above to current of trunk ? Well, it just does not make fun, to keep synchronized with trunk too long :-( jachym -- Jachym Cepicky e-mail: [EMAIL PROTECTED] URL: http://les-ejk.cz GPG: http://www.les-ejk.cz/pgp/jachym_cepicky-gpg.pub
signature.asc
Description: Toto je digitálně podepsaná část zprávy
_______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
