Oh totally, that's why it would be a post-commit and not pre-commit hook :-) We trust they'll do it, we just send a little robot behind to make sure they did their job. Sometimes people forget. sometimes people don't test in both browsers, etc....
Erik On 11/9/07, Pierre GIRAUD <[EMAIL PROTECTED]> wrote: > I think we currently hope that committers are sure to get all tests > passed before they commit. > Isn't it enough if we trust them ? > > Pierre > > On Nov 9, 2007 9:29 PM, Erik Uzureau <[EMAIL PROTECTED]> wrote: > > This sounds like a brilliant idea to me and I am heavily in favour. > > > > It seems like just adding one directory might be a little short though > > maybe we could do something like: > > > > openlayers/trunk/tests/acceptance > > and > > openlayers/trunk/tests/unit (for the current file-by-file tests?) > > > > Also, I think its probably a good time to start looking into a > > post-commit hook (only on trunk, of course) that runs the unit tests. > > I don't personally have the first clue as to how to do that but > > someone out there must? I think it would be a helpful addition to our > > process and (realistically) wouldn't hinder the dev process hardly at > > all. > > > > e > > > > > > > > > > On 11/9/07, Tim Schaub <[EMAIL PROTECTED]> wrote: > > > Hey- > > > > > > Our automated tests are a mix of acceptance and unit tests. These are > > > nice (because they are automated), but we need more (manual) acceptance > > > tests to fully test things like the renderers. > > > > > > Instead of scattering manual acceptance tests in the examples directory, > > > I'd like to have an "acceptance" directory in our "tests" directory (or > > > "manual" if that makes more sense to folks). This would make it clear > > > for developers what acceptance tests needed to be run manually, and > > > would make it less confusing to users who poke around the examples > > > directory and stumble into the weird examples that are actually tests > > > (speaking for myself here). > > > > > > Anyone opposed? Or got a better idea? > > > > > > Barring feedback, I think I'll make such a change on Monday. (This will > > > only involve adding a directory to the tests directory and starting to > > > compile regular manual acceptance tests there.) > > > > > > Tim > > > _______________________________________________ > > > Dev mailing list > > > [email protected] > > > http://openlayers.org/mailman/listinfo/dev > > > > > _______________________________________________ > > Dev mailing list > > [email protected] > > http://openlayers.org/mailman/listinfo/dev > > > _______________________________________________ > Dev mailing list > [email protected] > http://openlayers.org/mailman/listinfo/dev > _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
