We just discussed it with Eric at office. I agree with him on the fact that this is not a job for an OpenLayers format. Because I only need some (private and public) methods such as convertSVGToVML(), what we concluded is that the best way would be to have a new OpenLayers.Renderer.Converter simple object in a new Renderer/Converter.js file.
Does anybody disagree with that ? Regards, Pierre On Nov 13, 2007 8:50 PM, Eric Lemoine <[EMAIL PROTECTED]> wrote: > On Nov 13, 2007 2:42 PM, Pierre GIRAUD <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > This morning, I had a review on the Barbara's code with some tiny clean-up. > > The code works great at the moment. > > > > There is still one thing to be fixed. Currently, the codebase to > > convert SVG symbols to VML has been put into the VML.js file as global > > functions such as "convertSVGToVML". This isn't really clean. > > > > What about having a new Format.SVG class with a convertToVML method ? > > Any other suggestions ? > > Hmm... Concrete Format classes are meant to implement write() and > read(). read() reads data from a string and returns an object. write() > writes an object into a string. How would these two methods apply to > Format.SVG? > > -- > Eric > _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
