Christopher, I tend to agree with you. I've put in several patches, most I consider very non-invasive. Some have been looked at, some haven't.
OL is still a very young product, and I think it's ok to have the trunk be a little wild. :-) In fact, one thing that prevents me from using the trunk for normal development is the fact that I have so many changes to 2.5 that aren't in the trunk (that I think could be), that I need a stable version to base my changes off of, rather than getting caught by a fix/change that hoses me. It's entirely possible that there are several really good teams using OL but are off on their own branch or maintaining a locally changed copy (like me), preventing the groups best eyes from being on the trunk. John -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Christopher Schmidt Sent: Friday, December 14, 2007 6:52 AM To: [email protected] Subject: [OpenLayers-Dev] Review of patches, etc. I'm beginning to think I was a bit overzealous in stating that all patches should require an external review. I've been watching OpenLayers development lately, and although I agree that in principle, code review is a good thing, I think that it has seriously hamstrung the project over the past couple months, due to lack of development time from a few core committers who were able to help move things forward in the past. Getting more core committers is one helpful step in the right direction, but it doesn't completely solve the problem: we're still blocking on very simple (one line) patches due to lack of review. I'd like to float the idea of allowing commits to trunk without review at the discrestion of the patch author. We've got really great committers, and I think we have the ability to decide when things should/shouldn't go in without a review on every patch. That said, when API functionality is involved, I think more thna one person should be able to comment before it goes into trunk. So, I think that any patch which adds new APIMethods or APIProperties should probably be opened as a ticket, and comments should be sought on it before it goes into trunk. Additionally, we should be more proactive in discussing things both in tickets nd on the mailing lists when there is a suggestion in API change. How do other people feel about this? I don't want to continue to see one line patches left open for 6 months due to lack of review. Regards, -- Christopher Schmidt MetaCarta _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev No virus found in this incoming message. Checked by AVG Free Edition. Version: 7.5.503 / Virus Database: 269.17.1/1183 - Release Date: 12/13/2007 9:15 AM No virus found in this outgoing message. Checked by AVG Free Edition. Version: 7.5.503 / Virus Database: 269.17.2/1184 - Release Date: 12/14/2007 11:29 AM This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the sender. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
