Hi, On Jan 17, 2008 3:01 PM, Christopher Schmidt <[EMAIL PROTECTED]> wrote: > On Thu, Jan 17, 2008 at 02:49:06PM +0100, Andreas Hocevar wrote: > > I was thinking about other classes that also draw features, like > > Control.ModifyFeature. Many of them currently use layer.drawFeature. In > > the future, they could all use renderer.drawFeature, and just pass the > > renderIntent. > > Controls should not talk to Renderers. That's breaking an abstraction > barrier that I'm very much against breaking. Everything that the > controls do should go through the layer, I think.
If that is the case, we just do the whole thing on layer.drawFeature instead of renderer.drawFeature. > It's possible that this is not really true, and that the Renderer base > class -- accessible via layer.renderer -- is enough of an 'abstraction > barrier' that it can be treated as a sane abstraction level. I'm not > convinced of that, and until we make a concious decision otherwise, I > would encourage all Renderer functions to be used only within the Layer. > > > In that case, we could probably avoid code duplication > > when doing fallback checks in renderer.drawFeature instead of every > > other class that needs to draw features. > > That's fine -- we can still do that check at the layer.drawFeature level > though, no? Yes, that would be no problem. I'm in favour of that. Regards, Andreas. _______________________________________________ Dev mailing list [email protected] http://openlayers.org/mailman/listinfo/dev
