Let's start with PR, I can perform code review on it then we will convert to the patch file and will attach to the JIRA item According to the documentation: -- javadocs are required -- in case any additional configuration is required it worth to create page in /openmeetings-parent/openmeetings-server/src/site/xdoc with required steps, comments etc
On Tue, Aug 9, 2016 at 11:35 PM, Ankush Mishra <[email protected]> wrote: > Hey Maxim, > > Currently my repository is pretty much up to date on the OM sources. > > Should I make a Pull Request or a Patch? Either way is fine with me. Just > let me know where I have to do what in this regard. > > With regard to the Code Reviews, I'll be doing them this week. Also, feel > free to test my respository, here: https://github.com/ > TheAntimist/openmeetings/tree/3.2.x , if you do require a CalDAV server > to test it on, just let me know, I have a couple of temporary accounts > which can be used for testing. > > Also, Submission guidelines are here: https://developers.google.com/ > open-source/gsoc/help/work-product. > > A couple of things, I want to ask is, first, there's a mention of : > > There's documentation of what and why. > > Should I add anything specific? Other than Javadoc comments and so on, > which are already present. > > Also, for the Submission should I just link to all my commits on my > Openmeetings Repository, along with that should I also mention the caldav4j > modifications as well? Or should we do something else like link to the Bug > Tracker? > > Much Thanks > > Ankush Mishra > On 08/08/2016 11:08 AM, Maxim Solodovnik wrote: > > In case everything done, I would prefer you to prepare "official" patch to > OM > > GSOC rules for final evaluation were changed, so I prefer to get > everything prepared, then move forward > > this should include: > 1) merge latest OM sources to your branch > 2) prepare patch/PR > 3) complete couple of code reviews > 4) attach patch to JIRA issue > > both of as need to walk through code submit rules to ensure me don't miss > anything > > @Sebastian could you please also check this guide? > > -- > WBR > Maxim aka solomax > > > -- > Ankush Mishra > > -- WBR Maxim aka solomax
