solomax commented on a change in pull request #87:
URL: https://github.com/apache/openmeetings/pull/87#discussion_r426156058
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-sharer.js
##########
@@ -26,6 +26,16 @@ var Sharer = (function() {
, autoOpen: false
, resizable: false
});
+
+ // Fix to move the close icon on top of the .ui-dialog-titlebar
cause otherwise
+ // touch-events are broken and you won't be able to close the
dialog
+ var closeIcon =
sharer.parent().find('.ui-dialog-titlebar-close').clone();
Review comment:
I believe the easier and more straight-forward way would be:
`sharer.parent().find('.ui-dialog-titlebar-close').appendTo(sharer.parent())`
other code can be dropped ...
BTW I'm trying to use `let/const` instead of `var` in new code :)))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
