solomax commented on a change in pull request #88:
URL: https://github.com/apache/openmeetings/pull/88#discussion_r426222247
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
##########
@@ -5,8 +5,12 @@ var VideoManager = (function() {
function _onVideoResponse(m) {
const w = $('#' + VideoUtil.getVid(m.uid))
- , v = w.data()
- , peer = v.getPeer();
+ , v = w.data();
Review comment:
I would prefer shorter version: `, peer = v && v.getPeer();`
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
##########
@@ -82,8 +86,12 @@ var VideoManager = (function() {
case 'iceCandidate':
{
const w = $('#' +
VideoUtil.getVid(m.uid))
- , v = w.data()
- , peer = v.getPeer();
+ , v = w.data();
+ var peer;
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
