solomax commented on a change in pull request #93:
URL: https://github.com/apache/openmeetings/pull/93#discussion_r427487171
##########
File path:
openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java
##########
@@ -571,8 +572,12 @@ private void addCspRule(CSPHeaderConfiguration cspConfig,
CSPDirective key, Stri
}
public void updateCsp() {
- setGaCode(getString(CONFIG_GOOGLE_ANALYTICS_CODE, null));
+ if (!getBool(CONFIG_CSP_ENABLED, true)) {
+
WebApplication.get().getCspSettings().blocking().disabled();
+ return;
+ }
+ setGaCode(getString(CONFIG_GOOGLE_ANALYTICS_CODE, null));
Review comment:
this call should go **before** `CONFIG_CSP_ENABLED` check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
