CkNoSFeRaTU commented on a change in pull request #95:
URL: https://github.com/apache/openmeetings/pull/95#discussion_r428120890
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
##########
@@ -147,31 +148,65 @@ var VideoUtil = (function() {
const processor = _processor || __processTopToBottom;
return processor(area, rectNew, list);
}
- function _arrange() {
- const list = [];
- $(VIDWIN_SEL).each(function() {
- const v = $(this);
- v.css(_getPos(list, v.width(), v.height()));
- list.push(_getRect(v));
- });
+ function _arrange_set(v, list) {
+ var w, h, f, r = false;
+
+ switch (self.arrangeMode) {
+ case 1:
+ w = 240;
+ h = 180;
+ break;
+ case 2:
+ w = 120;
+ h = 90;
+ f = __processEqualsBottomToTop;
+ break;
+
+ default:
+ const v2 = v.find('.video').get(0);
+ w = v2 && parseInt(v2.style.width, 10);
Review comment:
Ahh... cab = can :-))) No, base is not guaranteed to be 10:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
