yeah agree, its better to run minify and then use a task to copy them into target directories
However I have discovered: mvn minify:minify Will not do anything. You need to explicitly call its executions with mvn minify:minify@room-js [and any other execution you want to trigger] It doesn't matter if the files changed or not. If you just run standalone mvn minify:minify, it doesn't compile anything. You always need the executions added in the command. Thanks, Seb Sebastian Wagner Director Arrakeen Solutions http://arrakeen-solutions.co.nz/ <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> On Sat, 15 Aug 2020 at 14:34, Maxim Solodovnik <solomax...@gmail.com> wrote: > Hello Sebastian, > > editing files in `target/**` might be bad idea due to these changes will > be lost after recompiling > > running `mvn minify:minify` is much better solution IMO > `cp` might be required due to assembly plugin is not being called > > On Sat, 15 Aug 2020 at 08:32, seba.wag...@gmail.com <seba.wag...@gmail.com> > wrote: > >> Would the cp commands be better as a separated script or as a maven goal >> in the pom.xml file ? >> >> Thanks, >> Seb >> >> Sebastian Wagner >> Director Arrakeen Solutions >> http://arrakeen-solutions.co.nz/ >> >> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >> >> >> On Sat, 15 Aug 2020 at 11:26, seba.wag...@gmail.com < >> seba.wag...@gmail.com> wrote: >> >>> >>> BUILD SUCCESS >>> >>> [INFO] >>> ------------------------------------------------------------------------ >>> >>> [INFO] Total time: 3.526 s >>> >>> Instead of 3-5 min!! >>> >>> >>> >>> Sebastian Wagner >>> Director Arrakeen Solutions >>> http://arrakeen-solutions.co.nz/ >>> >>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>> >>> >>> On Sat, 15 Aug 2020 at 11:24, seba.wag...@gmail.com < >>> seba.wag...@gmail.com> wrote: >>> >>>> and its also a lot faster if you do a >>>> >>>> mvn minify:minify@room-js minify:minify@interview-wb-js >>>> minify:minify@wb-js minify:minify@fileinput-js >>>> minify:minify@settings-js minify:minify@nettest-js >>>> minify:minify@chat-js >>>> >>>> cp -r target/generated-sources/main/java/org/apache/openmeetings/* >>>> target/openmeetings-web-5.0.0-SNAPSHOT/WEB-INF/classes/org/apache/openmeetings/* >>>> >>>> Sebastian Wagner >>>> Director Arrakeen Solutions >>>> http://arrakeen-solutions.co.nz/ >>>> >>>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>>> >>>> >>>> On Sat, 15 Aug 2020 at 11:21, seba.wag...@gmail.com < >>>> seba.wag...@gmail.com> wrote: >>>> >>>>> This one actually work >>>>> >>>>> startup with >>>>> cd openmeetings-web >>>>> mvn install -P allModules,quick,mysql jetty:run-exploded >>>>> -Dwicket.configuration=DEVELOPMENT >>>>> >>>>> any changes JS files just run: >>>>> >>>>> #!/bin/sh >>>>> mvn minify:minify@room-js >>>>> mvn minify:minify@interview-wb-js >>>>> mvn minify:minify@wb-js >>>>> mvn minify:minify@fileinput-js >>>>> mvn minify:minify@room-js >>>>> mvn minify:minify@settings-js >>>>> mvn minify:minify@nettest-js >>>>> mvn minify:minify@chat-js >>>>> >>>>> cp -r target/generated-sources/main/java/org/apache/openmeetings/* >>>>> target/openmeetings-web-5.0.0-SNAPSHOT/WEB-INF/classes/org/apache/openmeetings/* >>>>> >>>>> After that just reload the browser. It will work. >>>>> >>>>> theme.css I haven't done yet. But it should work similarly. >>>>> >>>>> It still takes too long, because Maven compiles even if there wasn't >>>>> actually any change. It would be much more clever and fast to just >>>>> recompile changed files. >>>>> >>>>> Thanks, >>>>> Seb >>>>> >>>>> Sebastian Wagner >>>>> Director Arrakeen Solutions >>>>> http://arrakeen-solutions.co.nz/ >>>>> >>>>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>>>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>>>> >>>>> >>>>> On Sat, 15 Aug 2020 at 10:45, seba.wag...@gmail.com < >>>>> seba.wag...@gmail.com> wrote: >>>>> >>>>>> Like triggering com.samaxes.maven standalone. >>>>>> >>>>>> This generates the JS files into ../generated-sources/main/java >>>>>> right now. >>>>>> >>>>>> All that's need for that to work is to also copy it to >>>>>> target/openmeetings-web-5.0.0-SNAPSHOT/WEB-INF/classes >>>>>> >>>>>> Thx >>>>>> Seb >>>>>> >>>>>> Sebastian Wagner >>>>>> Director Arrakeen Solutions >>>>>> http://arrakeen-solutions.co.nz/ >>>>>> >>>>>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>>>>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>>>>> >>>>>> >>>>>> On Sat, 15 Aug 2020 at 10:37, seba.wag...@gmail.com < >>>>>> seba.wag...@gmail.com> wrote: >>>>>> >>>>>>> There must be a way to speed up this cycle. >>>>>>> >>>>>>> => The way webpack and other tools work is that they monitor >>>>>>> directories and whenever there is a change in a file they (compile and) >>>>>>> copy it into the relevant folder. >>>>>>> >>>>>>> It would actually work similarly with OpenMeetings. >>>>>>> >>>>>>> I can for example run OpenMeetings with the Jetty build in: >>>>>>> cd openmeetings-web >>>>>>> mvn install -P allModules,quick,mysql jetty:run-exploded >>>>>>> -Dwicket.configuration=DEVELOPMENT >>>>>>> >>>>>>> and then if you navigate to: >>>>>>> >>>>>>> openmeetings-web/target/openmeetings-web-5.0.0-SNAPSHOT/WEB-INF/classes/org/apache/openmeetings/web/room/room.js >>>>>>> >>>>>>> If you edit this file, all to get this "live" is to refresh the >>>>>>> browser. No need to start or stop anything. Jetty will serve the changed >>>>>>> content! >>>>>>> >>>>>>> Now the only thing missing would be automatically copy (and compile) >>>>>>> those files into this directory, without doing a full Maven rebuild >>>>>>> and/or >>>>>>> restarts. Just some lightweight JS compile. >>>>>>> >>>>>>> With the goal so that you can still modify the files >>>>>>> in: >>>>>>> openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video.js >>>>>>> and it will run a lightweight task to compile and copy >>>>>>> to: >>>>>>> openmeetings-web/target/openmeetings-web-5.0.0-SNAPSHOT/WEB-INF/classes/x/y/z/*.js >>>>>>> >>>>>>> Do you have any ideas how to achieve such a lightweight maven build >>>>>>> that just does the JS/CSS tasks to generate this folder (without wiping >>>>>>> its >>>>>>> content) ? >>>>>>> >>>>>>> If we can get this done we speed up the cycle of change + retry by a >>>>>>> factor of 10. >>>>>>> >>>>>>> Thanks, >>>>>>> Seb >>>>>>> >>>>>>> Sebastian Wagner >>>>>>> Director Arrakeen Solutions >>>>>>> http://arrakeen-solutions.co.nz/ >>>>>>> >>>>>>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>>>>>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>>>>>> >>>>>>> >>>>>>> On Sat, 15 Aug 2020 at 02:16, Maxim Solodovnik <solomax...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hello Sebastian, >>>>>>>> >>>>>>>> On Fri, 14 Aug 2020 at 05:23, seba.wag...@gmail.com < >>>>>>>> seba.wag...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Have we found a way to modify the JavaScript and CSS files >>>>>>>>> _without_ triggering Maven tasks ? >>>>>>>>> >>>>>>>> >>>>>>>> I usually change JS/CSS in Dev console, test it then move these >>>>>>>> changes to IDE :))) >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> It takes 2-3 minutes to run Maven and a complete restart of the >>>>>>>>> OpenMeeting server. Your JSession is obviously also gone so you can re >>>>>>>>> login and navigate all the way back to where you were. >>>>>>>>> >>>>>>>> >>>>>>>> This can be improved if you will check "Remember me" on sign-in >>>>>>>> screen :) >>>>>>>> I have 2 different browsers with 2 different "saved" logins :) >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> It's just very tedious. >>>>>>>>> >>>>>>>>> There must be a way to speed up this cycle. >>>>>>>>> >>>>>>>> >>>>>>>> Not sure how this can be improved >>>>>>>> Any ideas are welcome :) >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Seb >>>>>>>>> >>>>>>>>> Sebastian Wagner >>>>>>>>> Director Arrakeen Solutions >>>>>>>>> http://arrakeen-solutions.co.nz/ >>>>>>>>> >>>>>>>>> <https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url> >>>>>>>>> <https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Best regards, >>>>>>>> Maxim >>>>>>>> >>>>>>> > > -- > Best regards, > Maxim >
