solomax commented on pull request #125: URL: https://github.com/apache/openmeetings/pull/125#issuecomment-772511791
Hello @ShangwenWang, Thanks for your PR! Unfortunately it can't be merged :( 1. as it is it will break the build (you change the method name, but not the code calling the method) According renaming: I'm -0 for it. I do prefer shorter names, and `XmlExport.toXml` not confusing In case static import will be used the call will be `toXml` - not confusing at all ... ``` ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
