sebawagner commented on a change in pull request #135:
URL: https://github.com/apache/openmeetings/pull/135#discussion_r587245236
##########
File path:
openmeetings-web/src/main/java/org/apache/openmeetings/web/admin/connection/ConnectionsPanel.java
##########
@@ -57,9 +57,9 @@
@SpringBean
private ClientManager cm;
Review comment:
We created the interface IClientManager to make sure we use the right
kind of API methods to access the clientManager (and to potentially change the
client manager into another storage option, like Redis or sth - something that
doesn't require increasing memory with number of users!)
But if we then wire up the concrete class instead of the Interface, that
will break it! You can't swap IClientManager with a different implementation
anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
