Just have added some review comments The code is very compact And I like the idea of using InfoWebService for customizing manifest :)
I would add 30 new icons I believe this is too much :( I would modify favicon to be SVG https://medium.com/swlh/are-you-using-svg-favicons-yet-a-guide-for-modern-browsers-836a6aace3df On Sun, 17 Oct 2021 at 07:03, [email protected] <[email protected]> wrote: > Done. I've added some details and screenshots in the PR and linked wiki > page. It's actually quite a small PR part from adding a few icons in > different resolutions. > > This adds so that when using the mobile browsers "Add to home screen" > function: > > - Show a nice icon in the screens and on the mobile device > - Show a nice name for the app in the mobile > - Show a nice splash screen when opening OpenMeetings after saving to > home screen on the mobile > - Remove url and navigation bar in browser so it uses the full screen > size > - Fix to landscape mode (Android only, iOS does not support it) > - Show a nice icon and name when rotating through currently open apps on > the mobile device > > You *may* call this PWA mode. However really it's just a fancy bookmark. > However it makes the application look much more like a native mobile app. > And it makes it easier to control the url/navigation bar of the browser. > > See documentation on mobile experience or iOS and Android here: > > https://cwiki.apache.org/confluence/display/OPENMEETINGS/OpenMeetings+Mobile#OpenMeetingsMobile-Savetohomescreentocreatebettermobileexperience > > *It has no impact on any other functionality of OpenMeetings (as well as it > does not require any rewrite of any functionality).* > > What could be done next: > > - Adding a prompt in iOS to suggest landscape mode (iOS "add to home > screen" functionality does not support orientation=landscape feature, > needs > user prompt when in portrait mode) > - Potentially something that makes this "Add to home screen" easier to > find for users > - Documentation on how to release to the App store. Using this "Add to > home screen" mode it is easier to also package it up to release > OpenMeetings to an App store > > Thanks > Seb > > Sebastian Wagner > Director Arrakeen Solutions, OM-Hosting.com > http://arrakeen-solutions.co.nz/ > https://om-hosting.com - Cloud & Server Hosting for HTML5 > Video-Conferencing OpenMeetings > < > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > < > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > On Sat, 16 Oct 2021 at 05:27, Maxim Solodovnik <[email protected]> > wrote: > > > On Wed, 13 Oct 2021 at 04:22, [email protected] < > [email protected] > > > > > wrote: > > > > > > > > > > Also I don't really like all these JS frameworks > > > > I believe the content should be controlled on server > > > > > > => There is no framework change, your understanding of PWA and saving > to > > > home screen I think is based on a misunderstanding. Or you mixing it > with > > > other topics around the other email thread on "Future of front end". It > > has > > > nothing to do with what framework you use. PWA does not mean the > > > application is more or less executed on the client or server side. It's > > > just a different way of starting a web-browser. That is all. > > > > > > > I wrote PWA for one client > > It was serverless app > > and as PWA it was working in offline mode > > AFAIK you need some cache and background worker > > > > If you feel it is easy and useful: I would say let's try :) > > > > > > > > > > Thanks > > > Seb > > > > > > Sebastian Wagner > > > Director Arrakeen Solutions, OM-Hosting.com > > > http://arrakeen-solutions.co.nz/ > > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > Video-Conferencing OpenMeetings > > > < > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > < > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > > > > > > On Wed, 13 Oct 2021 at 10:15, [email protected] < > > [email protected] > > > > > > > wrote: > > > > > > > Let me try out to see how many changes are required. And then we can > > see. > > > > I think your understanding of PWA is a misunderstanding. It's nothing > > > else > > > > than an alternative way of a browser. So you can control a few more > > > aspects > > > > more explicitly. > > > > > > > > It is not rewriting the JS or HTML files. Or changing the frameworks. > > > It's > > > > still just a browser. It just opens up a few APIs that you don't have > > > when > > > > using a normal browser. > > > > > > > > Thanks > > > > Seb > > > > > > > > Sebastian Wagner > > > > Director Arrakeen Solutions, OM-Hosting.com > > > > http://arrakeen-solutions.co.nz/ > > > > https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > > Video-Conferencing OpenMeetings > > > > > > > > < > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > > < > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > > > > > > > > > > On Wed, 13 Oct 2021 at 07:37, [email protected] < > > > [email protected]> > > > > wrote: > > > > > > > >> Why is it a rewrite? > > > >> > > > >> All you do is add a manifest file. In order to make saving to the > Home > > > >> Screen easier. > > > >> > > > >> What other change do you expect? > > > >> > > > >> Thx > > > >> Sebastian > > > >> > > > >> On Wed, 13 Oct 2021 at 4:32 AM, Ali Alhaidary < > > > >> [email protected]> wrote: > > > >> > > > >>> I second @Max > > > >>> > > > >>> Ali > > > >>> > > > >>> On 10/12/21 5:30 PM, Maxim Solodovnik wrote: > > > >>> > Hello Seb, > > > >>> > > > > >>> > I'm not happy with converting to PWA > > > >>> > This will mean to convert OM to JS+REST i.e. rewrite it > completely > > > one > > > >>> more > > > >>> > time > > > >>> > I doubt I can do another rewrite > > > >>> > Also I don't really like all these JS frameworks > > > >>> > I believe the content should be controlled on server > > > >>> > > > > >>> > But this is an open source project :) > > > >>> > > > > >>> > > > > >>> > On Tue, 12 Oct 2021 at 10:07, [email protected] < > > > >>> [email protected]> > > > >>> > wrote: > > > >>> > > > > >>> >> It is also possible to directly open the PWA instead of a new > > > Browser > > > >>> >> window for when opening OpenMeetings via an invitation link. So > > that > > > >>> it > > > >>> >> opens the PWA directly. You can simply add a special URL > > parameter: > > > >>> >> https://web.dev/pwa-url-handler/ > > > >>> >> > > > >>> >> So for invitation links we could potentially simply include the > > > >>> additional > > > >>> >> URL parameter for all links, if the PWA is installed it will > open > > it > > > >>> with > > > >>> >> this link. Otherwise open in a new browser window. Should have > no > > > >>> negative > > > >>> >> impact. > > > >>> >> > > > >>> >> In order to support versioning (or different installations of > > > >>> OpenMeetings) > > > >>> >> - in case a user has installed multiple OpenMeetings > installations > > > on > > > >>> the > > > >>> >> same mobile device - we can include the name in the PWA name, > so > > > >>> that it > > > >>> >> does separate those versions. This may not be even a problem, > but > > it > > > >>> might > > > >>> >> be very handy for developers so you have multiple different > icons > > on > > > >>> your > > > >>> >> home screen. Or in case we use the more advanced features of a > PWA > > > >>> (e.g. > > > >>> >> local storage). > > > >>> >> > > > >>> >> Thanks > > > >>> >> Seb > > > >>> >> > > > >>> >> Sebastian Wagner > > > >>> >> Director Arrakeen Solutions, OM-Hosting.com > > > >>> >> http://arrakeen-solutions.co.nz/ > > > >>> >> https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > >>> >> Video-Conferencing OpenMeetings > > > >>> >> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > >>> >> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > >>> >> > > > >>> >> On Tue, 12 Oct 2021 at 09:20, [email protected] < > > > >>> [email protected] > > > >>> >> wrote: > > > >>> >> > > > >>> >>> Are we happy to proceed to: > > > >>> >>> * Add manifest file and prompt to save to home screen on > Mobile > > > >>> devices > > > >>> >>> * Add prompt for mobile users to rotate device into landscape > > > mode > > > >>> >>> > > > >>> >>> Thanks > > > >>> >>> Seb > > > >>> >>> > > > >>> >>> Sebastian Wagner > > > >>> >>> Director Arrakeen Solutions, OM-Hosting.com > > > >>> >>> http://arrakeen-solutions.co.nz/ > > > >>> >>> https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > >>> >>> Video-Conferencing OpenMeetings > > > >>> >>> > > > >>> >>> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > >>> >>> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > >>> >>> > > > >>> >>> > > > >>> >>> On Mon, 11 Oct 2021 at 18:22, [email protected] < > > > >>> >> [email protected]> > > > >>> >>> wrote: > > > >>> >>> > > > >>> >>>> I would say OM is for landscape mode ... > > > >>> >>>>> Maybe we can show some message like: "OM will be much more > > useful > > > >>> in > > > >>> >>>>> landscape mode :)" ? > > > >>> >>>> => That was my first idea too. But I think if we go down that > > > path I > > > >>> >>>> would probably also suggest to prompt users to save > OpenMeetings > > > to > > > >>> the > > > >>> >>>> home screen on the mobile device (and by doing so converting > it > > > >>> into a > > > >>> >>>> Progressive Web App/PWA). Instead of just prompting for > > landscape > > > >>> mode. > > > >>> >>>> > > > >>> >>>> Cause once its a PWA we can: > > > >>> >>>> > > > >>> >>>> - Control full screen/display mode and maximise screen > usage > > > >>> (no back > > > >>> >>>> button, no URL navigation bar) - and especially the URL > bar > > > >>> stays > > > >>> >> away! The > > > >>> >>>> annoying thing is that if you scroll on iOS is will show > the > > > >>> URL bar > > > >>> >> again > > > >>> >>>> and makes the screen smaller > > > >>> >>>> - Orientation landscape (at least in Android, iOS show > > > >>> "unsupported > > > >>> >>>> orientation" - user friendly message) > > > >>> >>>> - Start OpenMeetings like a Mobile App via an Icon on your > > > home > > > >>> >>>> screen (it makes a huge difference actually to user > > behaviour) > > > >>> >>>> > > > >>> >>>> So it's a much more "native" feel when converted to PWA. And > the > > > >>> effort > > > >>> >>>> in order to convert to a PWA is pretty small (create manifest > > > file) > > > >>> >>>> > > > >>> >>>> In theory users can actually already save it to their home > > screen. > > > >>> >>>> OpenMeetings is just not using any of the features that would > > help > > > >>> to > > > >>> >> make > > > >>> >>>> it more user friendly in that case. > > > >>> >>>> > > > >>> >>>> So should we maybe rather prompt to "save to home screen" ? It > > > just > > > >>> >> seems > > > >>> >>>> to give more options to improve things. > > > >>> >>>> > > > >>> >>>> Thanks > > > >>> >>>> Seb > > > >>> >>>> > > > >>> >>>> Sebastian Wagner > > > >>> >>>> Director Arrakeen Solutions, OM-Hosting.com > > > >>> >>>> http://arrakeen-solutions.co.nz/ > > > >>> >>>> https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > >>> >>>> Video-Conferencing OpenMeetings > > > >>> >>>> > > > >>> >>>> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > >>> >>>> < > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > >>> >>>> > > > >>> >>>> On Mon, 11 Oct 2021 at 16:33, Maxim Solodovnik < > > > >>> [email protected]> > > > >>> >>>> wrote: > > > >>> >>>> > > > >>> >>>>> I would say OM is for landscape mode ... > > > >>> >>>>> Maybe we can show some message like: "OM will be much more > > useful > > > >>> in > > > >>> >>>>> landscape mode :)" ? > > > >>> >>>>> > > > >>> >>>>> On Sun, 10 Oct 2021 at 05:30, [email protected] < > > > >>> >>>>> [email protected]> > > > >>> >>>>> wrote: > > > >>> >>>>> > > > >>> >>>>>> I've updated the mobile viewports which makes OpenMeetings a > > lot > > > >>> more > > > >>> >>>>>> usable on a Mobile device. Especially when in portrait mode > it > > > was > > > >>> >>>>> pretty > > > >>> >>>>>> much impossible to click any button or icon.Since they are > > > >>> literally > > > >>> >>>>> 2x2 > > > >>> >>>>>> pixels in size on the screen. > > > >>> >>>>>> > > > >>> >>>>>> There are some sample screens of forms, for example on the > > login > > > >>> >> form: > > > >>> >>>>>> https://issues.apache.org/jira/browse/OPENMEETINGS-2685 > > > >>> >>>>>> or when you try to click the icons to share your webcam / > > > >>> microphone: > > > >>> >>>>>> https://issues.apache.org/jira/browse/OPENMEETINGS-2686 > > > >>> >>>>>> > > > >>> >>>>>> However now in portrait mode on the mobile device: The > > > whiteboard > > > >>> is > > > >>> >>>>> very > > > >>> >>>>>> small. This is in portrait mode. Landscape is proportionally > > > fine. > > > >>> >>>>>> See screenshots in > > > >>> >>>>> https://issues.apache.org/jira/browse/OPENMEETINGS-2686 > > > >>> >>>>>> It would be better if in portrait mode on a mobile device > > > screen: > > > >>> The > > > >>> >>>>>> whiteboard should use more space. For example by toggling > the > > > user > > > >>> >>>>> list to > > > >>> >>>>>> be "minimised" + adding some additional screen buttons for > > > sharing > > > >>> >>>>>> webcam/microphone (outside of the user list). > > > >>> >>>>>> > > > >>> >>>>>> I would argue the ability to share your audio/video is > > essential > > > >>> to > > > >>> >> be > > > >>> >>>>>> visible. Also on a mobile device. But you don't need to see > > all > > > >>> the > > > >>> >>>>> users > > > >>> >>>>>> in the user list constantly. More important to see the > > > whiteboard > > > >>> and > > > >>> >>>>> other > > > >>> >>>>>> users. However currently there isn't a way to minimise the > > user > > > >>> list > > > >>> >>>>> _and_ > > > >>> >>>>>> show the audio/video sharing buttons. I'm thinking of adding > > > this > > > >>> >>>>>> functionality. Just for mobile devices to become more > usable. > > > >>> >>>>>> > > > >>> >>>>>> Thanks > > > >>> >>>>>> Seb > > > >>> >>>>>> > > > >>> >>>>>> Sebastian Wagner > > > >>> >>>>>> Director Arrakeen Solutions, OM-Hosting.com > > > >>> >>>>>> http://arrakeen-solutions.co.nz/ > > > >>> >>>>>> https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > >>> >>>>>> Video-Conferencing OpenMeetings > > > >>> >>>>>> < > > > >>> >>>>>> > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > >>> >>>>>> < > > > >>> >>>>>> > > > >>> >> > > > >>> > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > >>> >>>>> > > > >>> >>>>> -- > > > >>> >>>>> Best regards, > > > >>> >>>>> Maxim > > > >>> >>>>> > > > >>> > > > > >>> > > > >> -- > > > >> Sebastian Wagner > > > >> Director Arrakeen Solutions, OM-Hosting.com > > > >> http://arrakeen-solutions.co.nz/ > > > >> https://om-hosting.com - Cloud & Server Hosting for HTML5 > > > >> Video-Conferencing OpenMeetings > > > >> > > > >> < > > > > > > https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url > > > > > > > >> < > > > > > > https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url > > > > > > > >> > > > > > > > > > > > > > -- > > Best regards, > > Maxim > > > -- Best regards, Maxim
