solomax commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732451204
##########
File path:
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##########
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
public static String getWebappPath() {
- String webappPath = baseUrl;
- if (webappPath.endsWith("/")) {
- webappPath = webappPath.substring(0,
webappPath.length() - 1);
+ try {
Review comment:
I have created the method to avoid code duplication :)
your current code is: `return URI.create(DEFAULT_BASE_URL);`
OK :)
you are right, I was too fast and not use compiler one more time :((
This code will work as expected:
```
private static URI getWebappPath(url) {
return URI.create(URI.create(url + "/").normalize().getPath());
}
public static URI getWebappPath() {
try {
return getWebappPath(baseUrl);
} catch (Exception e) {
return getWebappPath(DEFAULT_BASE_URL);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
