All annotations in metadatasharing were bare @Autowired, without ids of specific beans. I haven't tested how it would work if we added ids to the annotations, but I think that you are right and this will (should) be as fast as XML.
On Mon, Aug 8, 2011 at 7:32 AM, Mark Goodrich <[email protected]> wrote: > Does this appear to mainly be an issue with the “@autowire” annotation, or > do other Spring annotations seem to cause similar issues? > In metadatasharing we use spring annotations everywhere it is possible. Only autowiring services and DAOs caused big slow down (i.e. 10x more time to module load). Other annotations probably have some performance impact, but it is hard to notice this for sure. -- Piotr Bryk On Tue, Aug 9, 2011 at 12:47 AM, Darius Jazayeri <[email protected]>wrote: > By the way, Piotr and Dave, do you know if the @Autowired annotations you > removed were by-type or by-id? E.g. I would have assumed that > @Autowired("id-of-specific-bean") is just as fast as XML, and it might have > been less work to rewrite things that way. > > -Darius > > > On Mon, Aug 8, 2011 at 7:32 AM, Mark Goodrich <[email protected]> wrote: > >> Mike also backported this fix to 1.6.x, but I’m not sure which release >> (probably 1.6.3?) it got it.**** >> >> ** ** >> >> Does this appear to mainly be an issue with the “@autowire” annotation, or >> do other Spring annotations seem to cause similar issues?**** >> >> ** ** >> >> Mark**** >> >> ** ** >> >> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Ben Wolfe >> *Sent:* Sunday, August 07, 2011 12:13 PM >> *To:* [email protected] >> *Subject:* Re: [OPENMRS-DEV] @autowire annotation, slow module loading*** >> * >> >> ** ** >> >> I'd be interested to know if its just as fast again with 1.8 and those >> modules. Mike fixed a module classloader slowdown problem causing spring >> startup to crawl.**** >> >> Ben**** >> >> On Aug 7, 2011 4:24 PM, "Dave Thomas" <[email protected]> wrote:**** >> ------------------------------ >> >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> **** >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
