Darius, This was a quick profile of our live clinic feeds on our test machine. Basically patients come in, get registered, and it fires off rules to create forms for them to fill out. There were five patients that came in during the elapsed time. From the times I'm seeing in our logs, it should take only around 7% of the time we're seeing in the snapshot (~46 seconds).
I'm going to set up a repeatable test today so I can get some better measurements. I'll let you know once I get this completed. Steve From: [email protected] [mailto:[email protected]] On Behalf Of Darius Jazayeri Sent: Friday, August 12, 2011 5:05 PM To: [email protected] Subject: Re: [OPENMRS-DEV] Logic Transactional Annotations Steve, What is this a profile of? I see about 11 minutes of CPU time, but can you give some context? How much time did you expect this to take? How many rules were run? For how many people? -Darius On Fri, Aug 12, 2011 at 12:51 PM, McKee, Steven Jay <[email protected]<mailto:[email protected]>> wrote: Yeah, I bet it got dropped because of size. I attached it to the following ticket: https://tickets.openmrs.org/browse/TRUNK-2526 Thanks, Steve From: [email protected]<mailto:[email protected]> [mailto:[email protected]<mailto:[email protected]>] On Behalf Of Darius Jazayeri Sent: Friday, August 12, 2011 3:32 PM To: [email protected]<mailto:[email protected]> Subject: Re: [OPENMRS-DEV] Logic Transactional Annotations I don't see an attachment here. Perhaps it's too big? Can you attach it to a ticket? -Darius On Fri, Aug 12, 2011 at 12:15 PM, McKee, Steven Jay <[email protected]<mailto:[email protected]>> wrote: I've attached a Yourkit snapshot of the process. I agree with Ben that it's probably opening up multiple transactions since we removed the annotation from LogicService. It was the high level place where all the processing started. Thanks, Steve From: [email protected]<mailto:[email protected]> [mailto:[email protected]<mailto:[email protected]>] On Behalf Of Darius Jazayeri Sent: Friday, August 12, 2011 2:25 PM To: [email protected]<mailto:[email protected]> Subject: Re: [OPENMRS-DEV] Logic Transactional Annotations Are you able to run the Yourkit profiler against your running app? I'd be happy to help interpret a yourkit snapshot. -Darius On Fri, Aug 12, 2011 at 10:48 AM, McKee, Steven Jay <[email protected]<mailto:[email protected]>> wrote: I removed the transactional annotation from the LogicService interface, but I'm seeing tremendous slowdowns in our rule processing. Rule processing to create one of our forms usually takes around 7-10 seconds to complete. After the logic change, it's taking around 30-70 seconds. I tried applying the read-only transactional annotation to the logic DAO's, but that didn't make a difference either. I also modified our Arden parser to make our rules use the LogicContext object instead of LogicService (as suggested earlier in this thread) within logic rules, but that didn't make a difference either. I apologize if this message gets posted to the developers list multiple times. I have issues about every time I try to post a message, and no one has been able to figure out why. Steve From: [email protected]<mailto:[email protected]> [mailto:[email protected]]<mailto:[mailto:[email protected]]> On Behalf Of Darius Jazayeri Sent: Tuesday, August 02, 2011 2:43 PM To: [email protected]<mailto:[email protected]> Subject: Re: [OPENMRS-DEV] Logic Transactional Annotations Steve, can you attach this as a patch against 1.7.x on the relevant ticket, for code review and inclusion? (If you can comment on how much testing you've done after making this fix, that'd be helpful. Surely it'll be 1000% more than the testing anyone else has done on logic.) -Darius ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
