I will put it on the ticket .

On Mon, Sep 19, 2011 at 4:51 PM, Ben Wolfe <[email protected]> wrote:

> I agree that just whitespace should not be a valid reason.  Is your new
> patch on the ticket?
>
> Ben
>
> On Mon, Sep 19, 2011 at 1:25 AM, Gaurav Chugh <[email protected]>wrote:
>
>> The patch fix(https://source.openmrs.org/cru/CR-TRUNK-504) does not solve
>> the problem  ,it still gives error if you enter white spaces ,in the reason
>> input text field .
>> I used the code from above patch , to build war file ,& then deployed it
>> to 
>> http://patcherror.jelastic.com/<http://patcherror.jelastic.com/patientDashboard.form?patientId=2&phrase=harr>
>> .
>>
>> Steps to reproduce the problem :
>>
>>    1. Go to
>>    
>> http://patcherror.jelastic.com/patientDashboard.form?patientId=2&phrase=harr
>>    (username-admin , password-Test1234) .
>>    2. Add a new relationship between the users Harry & Mike .
>>    3. Click on cross button , to remove the relationship.
>>    4. Enter white spaces in the text input field.
>>    5. The relationship is removed .
>>
>> I tried to correct it , and deployed another war file .According , to what
>> I could think , the solution must be
>>                 if(reason.trim().length==0){
>>                     alert("Please enter a valid reason");
>>                 }
>>                 else if (reason != null && reason != '') {
>>                         DWRRelationshipService.voidRelationship(relId,
>> reason, refreshRelationships);
>>                 }
>> I have deployed openMRS  , with above code at ,
>> http://chughgaurav.jelastic.com/openmrs/patientDashboard.form?patientId=2&phrase=harry
>>  .
>>
>> Ticket Reference - 
>> https://tickets.openmrs.org/browse/TRUNK-2590<https://tickets.openmrs.org/browse/TRUNK-2590?page=com.atlassian.jirafisheyeplugin:crucible-issuepanel#issue-tabs>
>>  .
>>
>> --
>> Regards ,
>> Gaurav Chugh
>>
>>  ------------------------------
>> Click here to 
>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
>> OpenMRS Developers' mailing list
>
>
> ------------------------------
> Click here to 
> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
> OpenMRS Developers' mailing list




-- 
Regards ,
Gaurav

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to