Yes, but that is not what this thread is about. This is about whether we should change our maven template for modules to play nicer with new developers and eclipse. (with the unfortunate side effect of both a .jar and .omod file being created)
Ben On Fri, Sep 23, 2011 at 3:29 PM, Burke Mamlin <[email protected]>wrote: > If the omod contains more than is needed for a maven artifact, could we > make a process to strip out what is not needed from the omod? In other > words, authors need only upload their omod to the module repository and a > script could convert the omod to a jar for maven & deploy it to maven. > > -Burke > > > On Fri, Sep 23, 2011 at 2:47 AM, Ben Wolfe <[email protected]> wrote: > >> The omod contains more. The omod has the lib folder which contains both >> the module api jar and any other unique library dependencies defined by the >> module. >> >> If everyone is ok with this I'll commit changes to the few mavenized I >> know about and then change the scripts on the mavenization wiki page: >> https://wiki.openmrs.org/display/docs/Converting+old+code+to+Maven >> >> Ben >> >> >> On Thu, Sep 22, 2011 at 5:20 PM, Darius Jazayeri <[email protected] >> > wrote: >> >>> It's fine by me. Is the jar in omod/target just exactly like the omod but >>> with a different file extension? Or does it only have classes or something? >>> >>> -Darius >>> >>> On Wed, Sep 21, 2011 at 6:13 AM, Ben Wolfe <[email protected]> wrote: >>> >>>> Currently if you check out a mavenized module eclipse will fail to >>>> recognize the "omod" project as a java project. This is because we have >>>> "packaging" set to "omod" in the pom.xml. If packaging is "jar" eclipse is >>>> ok with things and everything works out of the box/checkout with eclipse. >>>> >>>> The openmrs module maven plugin that Matt and Co wrote looks at this >>>> packaging type and so knows what files to put into the generated >>>> target/moduleid.omod. >>>> >>>> Matt looked into a solution and modified the plugin and pom slightly to >>>> allow for the pom.xml packaging to be "jar". >>>> >>>> *Question:* >>>> After the modification, when the module is packaged both a jar and an >>>> omod file is put into omod/target. >>>> >>>> Is this an acceptable trade-off to people to make module startup easier >>>> for folks? >>>> >>>> Ben >>>> ------------------------------ >>>> Click here to >>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>> OpenMRS Developers' mailing list >>> >>> >>> ------------------------------ >>> Click here to >>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>> OpenMRS Developers' mailing list >> >> >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
