I believe some of these concepts were "replaced" but ended up "retired".
 I'm not sure why this happened originally, but at this point I understand
the desire to keep concept names distinct.  I have not seen the Advanced
Concept Management Module until now, so I will take a look at how that might
help in this situation.

Jeremy Keiper
OpenMRS Core Developer
AMPATH / IU-Kenya Support


On Tue, Sep 27, 2011 at 1:42 PM, Wyclif Luyima <[email protected]> wrote:

> Can we discuss this on the design call tomorrow? And come up with a general
> convention on when to deem a value as a duplicate for columns that are meant
> to be unique, i believe there are different forms of being a duplicate i.e
> in the database or the API or both.
>
> But i agree with Darius that retired and voided rows should be considered
> when  finding duplicates, so this means that probably the concept validator
> needs to be fixed also to disallow names being used by duplicate concepts
> since it isn't the case right now.
>
> Wyclif
>
> On Tue, Sep 27, 2011 at 1:27 PM, Darius Jazayeri 
> <[email protected]>wrote:
>
>> Certainly it would be nice to have a "merge concepts" feature, which also
>> merges obs for those concepts. I don't know how that would play in the
>> presence of sync though.
>>
>> This would be nice to add as a feature in the Advanced Concept 
>> Management<https://wiki.openmrs.org/x/wQ0z>
>>  module.
>>
>> -Darius
>>
>>
>> On Tue, Sep 27, 2011 at 9:58 AM, Jeremy Keiper <[email protected]>wrote:
>>
>>> Is it a good idea, if a non-retired concept means the same thing as the
>>> same-named retired concept, to migrate those obs to refer to the non-retired
>>> concept?
>>>
>>> Since the API frowns on this situation (having retired concepts with the
>>> same names as non-retired concepts), should core do something consistent to
>>> "fix" the bad data?
>>>
>>>
>>> Jeremy Keiper
>>> OpenMRS Core Developer
>>> AMPATH / IU-Kenya Support
>>>
>>>
>>> On Tue, Sep 27, 2011 at 12:42 PM, Darius Jazayeri <
>>> [email protected]> wrote:
>>>
>>>> The short answer is that in OpenMRS, retired does not mean deleted. So
>>>> you're not allowed to have two concepts with the same fully-specified name
>>>> in a locale, even if one is retired. The correct fix is to rename one
>>>> (presumably the retired one).
>>>>
>>>> -Darius
>>>>
>>>> On Tue, Sep 27, 2011 at 8:42 AM, Jeremy Keiper <[email protected]>wrote:
>>>>
>>>>> I have two concepts, both with the same FULLY_SPECIFIED name, but one
>>>>> is retired and the other is not.  If I want to use Metadata Sharing Module
>>>>> to export these concepts, the retired one will come back as failing the
>>>>> ConceptValidator, as follows:
>>>>>
>>>>> Concept [a8963c04-1350-11df-a1f1-0026b9348838] 'BACK' is a duplicate
>>>>> name in locale 'en'
>>>>>
>>>>> I have no problem exporting the non-retired concept.  There are no
>>>>> other objects in the export outside of these concepts, and I tried 
>>>>> exporting
>>>>> just the retired concept as well (getting the same error).
>>>>>
>>>>> Should the ConceptValidator recognize retired concepts and allow for
>>>>> duplicate names if the concept is remaining retired?  I believe the same
>>>>> error arises when trying to unretire or edit the retired concept through 
>>>>> the
>>>>> UI.
>>>>>
>>>>> Jeremy Keiper
>>>>> OpenMRS Core Developer
>>>>> AMPATH / IU-Kenya Support
>>>>>  ------------------------------
>>>>> Click here to 
>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from
>>>>>  OpenMRS Developers' mailing list
>>>>
>>>>
>>>> ------------------------------
>>>> Click here to 
>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from
>>>>  OpenMRS Developers' mailing list
>>>
>>>
>>> ------------------------------
>>> Click here to 
>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
>>> OpenMRS Developers' mailing list
>>>
>>
>> ------------------------------
>> Click here to 
>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
>> OpenMRS Developers' mailing list
>>
>
> ------------------------------
> Click here to 
> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
> OpenMRS Developers' mailing list
>

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to